bugs in sdf_exporter.py #2678
bugs in sdf_exporter.py #2678
Conversation
There was a problem hiding this comment.
Thanks for the contribution. Would you mind signing-off on your commits (see contributing guide.
There was a problem hiding this comment.
Thanks again for the contribution! I started reviewing it, but I quickly realized there are a lot of unrelated changes (e.g. style, removed comments, etc.) that make it harder to review. Could you please revert those changes keeping only the relevant changes that fix the bugs so the PR is as small as possible?
| filter_folder=True, | ||
| filemode=8, | ||
| ) | ||
| bpy.ops.wm.collada_export(filepath=prefix_path+meshes_folder_prefix+dae_filename, |
There was a problem hiding this comment.
Can we keep the path.join here? That is preferred over using + for paths. And since there aren't any other changes, could you revert this to the previous version to reduce the diff as much as possible.
| dae_filename = 'model.dae' | ||
| sdf_filename = 'model.sdf' | ||
| model_config_filename = 'model.config' | ||
| lightmap_filename = 'LightmapBaked.png' | ||
| model_name = 'my_model' | ||
| meshes_folder_prefix = 'meshes/' | ||
|
|
There was a problem hiding this comment.
No need to remove the extra space. Please revert and minimize the diff.
|
|
||
| ######################################################################################################################## | ||
| ### Exports model.dae of the scene with textures, its corresponding model.sdf file, and a default model.config file #### | ||
| ######################################################################################################################## |
There was a problem hiding this comment.
Any reason for removing this comment?
| #### export sdf xml based off the scene ##### | ||
| ############################################# | ||
| sdf = ET.Element("sdf", attrib={"version": "1.8"}) | ||
| mesh_objects = [o for o in objects if o.type == 'MESH'] |
There was a problem hiding this comment.
Please revert unnecessary changes. This is only changing double quotes to single quotes. The rest of the file uses double quotes and I think it's best to stick with that.
mahit2609
force-pushed
the
gz-sim9
branch
2 times, most recently
from
10801a9 to
d7a295a
Compare
Signed-off-by: mahit2609 <[email protected]>
| linear = ET.SubElement(attenuation, "linear") | ||
| linear.text = "1.0" | ||
| quadratic = ET.SubElement(attenuation, "quadratic") | ||
| quadratic.text = "0.0" | ||
| constant = ET.SubElement(attenuation, "constant") | ||
| constant.text = "1.0" |
There was a problem hiding this comment.
Can we not get these values from the blender light anymore? Why do we need to hardcode them? If not, can you add a comment at the top of the file saying light attenuation is not supported or something to that extent?
Fix Blender SDF Export Tool for Blender 4.2.3
Overview
This PR fixes compatibility issues with Blender 4.2.3, as the original code was non-functional in newer Blender versions. The changes include API updates and bug fixes to ensure proper functionality.
Key Changes
Updated code to work with Blender 4.2.3's API
Fixed broken light handling and material processing
Updated type checks and property access to match current Blender standards
Notes
Tested working on Blender 4.2.3
Previous version was non-functional on newer Blender releases
Maintains same export format for model.dae, model.sdf, and model.config files